Change locators in DasboardWorkspace page object #6723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st and status of workspace
SkorikSergey
added
kind/task
musienko-maxim
approved these changes
Oct 13, 2017
dmytro-ndp
reviewed
Oct 13, 2017
| @@ -99,7 +99,7 @@ public String getName() { | |||
| "//div[contains(@class,'che-toolbar')]//span[contains(text(),'%s')]"; | |||
| String WORKSPACES_LIST = "//ng-transclude[@class='che-list-content']"; | |||
| String WORKSPACE_ITEM_NAME = | |||
| "//div[contains(@class, 'che-list-item-name')]/span[contains(text(),'%s')]"; | |||
| "//div[contains(@class, 'workspace-name-clip')]//div[contains(@data-str, '%s')]"; | |||
There was a problem hiding this comment.
It may be reasonable to use debug-id here instead of xpath,
There was a problem hiding this comment.
It will be done by #6686.
dmytro-ndp
reviewed
Oct 13, 2017
| @@ -116,7 +116,7 @@ public String getName() { | |||
| String RUN_WORKSPACE_BTN = "//button/span[text()='Run']"; | |||
| String STOP_WORKSPACE_BTN = "//button/span[contains(text(),'Stop')]"; | |||
| String DELETE_WORKSPACE_BTN = "//button/span[text()='Delete']"; | |||
| String STATE_WORKSPACE = "//span[contains(@class, '%s')]"; | |||
| String STATE_WORKSPACE = "//div[contains(@class, 'workspace-status')]/span[text()='%s']"; | |||
There was a problem hiding this comment.
It may be reasonable to use debug-id here instead of xpath,
There was a problem hiding this comment.
It will be done by #6686.
tolusha
approved these changes
Oct 13, 2017
benoitf
removed
the
status/code-review
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4136/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We need: