Selenium: adapt selenium tests according to changes in a workspace creation flow #8349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
status/code-review
tolusha
approved these changes
Jan 18, 2018
dmytro-ndp
reviewed
Jan 18, 2018
| @@ -181,7 +182,7 @@ public void clickOnSaveChangesBtn() { | |||
| } | |||
|
|
|||
| public void clickOnCancelChangesBtn() { | |||
| loader.waitOnClosed(); | |||
| WaitUtils.sleepQuietly(3); | |||
There was a problem hiding this comment.
Please, comment sleep here and why we need exact 3 seconds.
dmytro-ndp
reviewed
Jan 18, 2018
| .click(); | ||
| } | ||
|
|
||
| public void clickOnCreateButtonAndStartWorkspace() { |
There was a problem hiding this comment.
According to the commands inside, the method name should be "clickOnCreateButtonAndOpenInIDE"
…uttonAndOpenInIDE
dmytro-ndp
approved these changes
Jan 18, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adapts selenium tests, that create a new workspace from the Dashboard, after changing a workspace creation flow by #8338.
This PR will be merged after #8338.
What issues does this PR fix or reference?
#8348