Selenium: Rework methods from "CodenvyEditor" page object with using "SeleniumWebDriverHelper" and "WebDriverWaitFactory" classes #8980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changes in related methods
…ect into the interface
…r' page object's body
…vork-methods-editor
…rations from 'String' to 'By'
…e/che into selen-revork-methods-editor
…vork-methods-editor
…riverHelper and WebDriverWaitFactory classes
Ohrimenko1988
added
status/code-review
dmytro-ndp
reviewed
Mar 1, 2018
|
|
||
| new WebDriverWait(seleniumWebDriver, LOAD_PAGE_TIMEOUT_SEC) | ||
| webDriverWaitFactory | ||
| .get(DEFAULT_TIMEOUT) |
There was a problem hiding this comment.
We can omit DEFAULT_TIMEOUT parameter by creation WebDriverWaitFactory#get() method which uses DEFAULT_TIMEOUT inside.
There was a problem hiding this comment.
Good point, thanks for the idea.
|
ci-test |
|
ci-test build report: |
…vork-methods-editor
… and apply this changes in the 'CodenvyEditor' page object
dmytro-ndp
approved these changes
Mar 2, 2018
…rPropByDoubleClick(String expectedItem)' and remove 'try/catch' blocks from related tests
SkorikSergey
approved these changes
Mar 2, 2018
dmytro-ndp
approved these changes
Mar 2, 2018
Ohrimenko1988
removed
the
status/code-review
hkolvenbach
pushed a commit
to hkolvenbach/che
that referenced
this pull request
Mar 12, 2018
…"SeleniumWebDriverHelper" and "WebDriverWaitFactory" classes (eclipse-che#8980)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rework methods from "CodenvyEditor" page object with using "SeleniumWebDriverHelper" and "WebDriverWaitFactory" classes
What issues does this PR fix or reference?
Issue: #8962
Release Notes
Docs PR