-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selenium: Rework methods from "CodenvyEditor" page object with using "SeleniumWebDriverHelper" and "WebDriverWaitFactory" classes #8980
Conversation
…changes in related methods
…ect into the interface
…r' page object's body
…vork-methods-editor
…rations from 'String' to 'By'
…e/che into selen-revork-methods-editor
…vork-methods-editor
…riverHelper and WebDriverWaitFactory classes
|
||
new WebDriverWait(seleniumWebDriver, LOAD_PAGE_TIMEOUT_SEC) | ||
webDriverWaitFactory | ||
.get(DEFAULT_TIMEOUT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can omit DEFAULT_TIMEOUT parameter by creation WebDriverWaitFactory#get()
method which uses DEFAULT_TIMEOUT
inside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks for the idea.
ci-test |
ci-test build report: |
…vork-methods-editor
… and apply this changes in the 'CodenvyEditor' page object
…rPropByDoubleClick(String expectedItem)' and remove 'try/catch' blocks from related tests
…"SeleniumWebDriverHelper" and "WebDriverWaitFactory" classes (eclipse-che#8980)
What does this PR do?
Rework methods from "CodenvyEditor" page object with using "SeleniumWebDriverHelper" and "WebDriverWaitFactory" classes
What issues does this PR fix or reference?
Issue: #8962
Release Notes
Docs PR