Fixed removing of PVCs when OpenShift project name is predefined #9437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
added
kind/bug
akorneta
approved these changes
Apr 16, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The bug appeared on OpenShift infrastructure because of
che.infra.kubernetes.namespaceconfiguration property. It is used by few components which are bound for both Kubernetes and OpenShift infrastructure. But OpenShift infrastructure introduces a new property calledche.infra.openshift.projectand ignore old one. So components used non-configured property, it was a reason why WorkspacePVCCleaner doesn't subscribe to WorkspaceRemoved events.This PR introduces changes to avoiding injection of
che.infra.kubernetes.namespaceconfiguration property. Instead of it, components should use other components like KubernetesNamespaceFactory, KubernetesNamespace, which are overridden by OpenShift infrastructure (OpenShiftProjectFactory, OpenShiftProject).What issues does this PR fix or reference?
#9431
Release Notes
N/A
Docs PR
N/A