Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace PVCs aren't deleted when pods get created in one namespace #9431

Closed
ghost opened this issue Apr 16, 2018 · 0 comments
Closed

Workspace PVCs aren't deleted when pods get created in one namespace #9431

ghost opened this issue Apr 16, 2018 · 0 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@ghost
Copy link

ghost commented Apr 16, 2018

Description

When workspace objects are created in one shared namespace (either in a namespace with server itself or their own dedicated namespace), workspace deletion does not delete associated pvcs. As a result, each deleted workspace leaves 2 pvcs hanging out there. They are bound to PVs, thus making them unavailable for new workspaces.

Reproduction Steps

  1. Deploy Che to OpenShift with CHE_INFRA_OPENSHIFT_PROJECT=eclipse-che or any other namespace

  2. Create and start a workspace

  3. Stop & delete a workspace.

PVCs have not been deleted.

image

eugene@ivantsoft ~/tools/gopath/src/github.com/eivantsov/che-cli (master) $ oc get pv
NAME      CAPACITY   ACCESSMODES   RECLAIMPOLICY   STATUS      CLAIM                                      STORAGECLASS   REASON    AGE
pv0042    100Gi      RWO,ROX,RWX   Recycle         Bound       eclipse-che/claim-che-workspace-sfq5ghh4                            2d                                                            2d
pv0064    100Gi      RWO,ROX,RWX   Recycle         Bound       eclipse-che/claim-che-workspace-ahw4bm2p                            2d                                                          2d
pv0070    100Gi      RWO,ROX,RWX   Recycle         Bound       eclipse-che/che-data-volume                                         2d

I've run into a problem with lack of pvs when testing https://github.com/eclipse/che/tree/templates where templates define the following behavior:

  1. No username/password or token is used to create workspace objects (che SA is used), and thus
  2. All workspace objects are created in the same namespace with Che

QA tests failed at some point, because workspaces are created and deleted during QA cycle, and in a short while OpenShift cluster was unable to satisfy more claims.

@ghost ghost added team/platform severity/P1 Has a major impact to usage or development of the system. labels Apr 16, 2018
@skabashnyuk skabashnyuk added the kind/bug Outline of a bug - must adhere to the bug report template. label Apr 16, 2018
@sleshchenko sleshchenko self-assigned this Apr 16, 2018
@sleshchenko sleshchenko added the status/in-progress This issue has been taken by an engineer and is under active development. label Apr 16, 2018
@sleshchenko sleshchenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Apr 16, 2018
@sleshchenko sleshchenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

2 participants