-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing service terminations #9658
Add missing service terminations #9658
Conversation
* Terminates {@link ProbeScheduler}. | ||
* | ||
* @author Sergii Leshchenko | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Singleton ?
/** | ||
* Terminates {@link ThreadPullLauncher}. | ||
* | ||
* @author Anton Korneta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like authorship was unintentionally copied from another class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's original authorship. I separated these changes from hot_update
PR.
aabe905
to
1cb5130
Compare
ci-test |
ci-test build report: |
052eb29
to
53fbced
Compare
53fbced
to
8829094
Compare
What does this PR do?
Add service terminations for CronThreadPull and ProbeScheduller.
Move removing of the temporary workspaces from @PreDestroy phase to WorkspaceTerminationService. It is needed to make sure that temporary workspaces will be stopped before removing.
Minor change: fix logging of errors which may occur during server status updating.
What issues does this PR fix or reference?
#9415
Release Notes
N/A
Docs PR
N/A