PI improvements #6229
Merged
PI improvements #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexDBlack
suggested changes
Aug 21, 2018
| import java.util.concurrent.locks.ReentrantReadWriteLock; | ||
|
|
||
| /** | ||
| * This ParallelInference implementation provides inference functionality without launching additional threads, so inference happens in the calling thread |
There was a problem hiding this comment.
More javadoc - limitations, when to use.
Also how to build one (i.e., "use PI builder configured with X, not this class") - that might not be obvious to users at first glance (it wasn't for me)
| } | ||
|
|
||
|
|
||
| public static class ModelSelector { |
There was a problem hiding this comment.
Make protected/private, unless there's a reason for it to be public?
| BATCHED, | ||
|
|
||
| /** | ||
| * Inference will applied in the calling thread instead of workers. |
There was a problem hiding this comment.
More javadoc - limitations, etc
| ROUND_ROBIN, | ||
|
|
||
| /** | ||
| * in this mode we'll be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP; DO NOT MERGE;
This PR adds: