Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix 9727 #9728

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Bugfix 9727 #9728

merged 2 commits into from
Jul 8, 2022

Conversation

j-d-o
Copy link
Contributor

@j-d-o j-d-o commented Jul 7, 2022

What changes were proposed in this pull request?

A bugfix to #9727 in form of a pull request as suggested by https://github.com/agibsonccc

How was this patch tested?

no tests touched or run - just the obvious wrong variable name corrected

@agibsonccc
Copy link
Contributor

@j-d-o this looks good. Mind signing the ECA? (Sorry eclipse foundation :) see: https://deeplearning4j.konduit.ai/multi-project/how-to-guides/contribute/eclipse-contributors

@j-d-o
Copy link
Contributor Author

j-d-o commented Jul 8, 2022

I did, anything else ?

@agibsonccc agibsonccc self-requested a review July 8, 2022 08:26
@agibsonccc agibsonccc merged commit cea4164 into deeplearning4j:master Jul 8, 2022
@agibsonccc
Copy link
Contributor

Great job! Thanks merged!

@j-d-o
Copy link
Contributor Author

j-d-o commented Jul 8, 2022

Thank you ... Im hoping for a next release soon. Thank you all for doing open source in the first place!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agibsonccc agibsonccc agibsonccc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-d-o @agibsonccc @TWJoachim