Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce using the english locae for dateparsing #48

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jun 8, 2023

Currently the parsing is sensitive to the used locale, leading to failed parsing if the system uses e.g. the german local by default.

This enforces to use always ENGLISH as a locae for parsing.

Currently the parsing is sensitive to the used locale, leading to failed
parsing if the system uses e.g. the german local by default.

This enforces to use always ENGLISH as a locae for parsing.
@scottslewis
Copy link
Contributor

Hi @laeubi

I've merged the fix (thanks), but It wasn't my intention to produce a new release of ECF until after the 3.28 release.

I read through eclipse-equinox/p2#206 and I can't tell from that discussion if javahttpclient switch is planned for 3.28 or not...but my assumption would be not (aren't we past freezes?)....especially since ECF is -1 project.

In any event, I can't produce a new ECF build this weekend (I'm off), and so the soonest I could have an ECF new version (with version updates, etc) would probably be 13th or 14th.

Please let me know how you would like to proceed.

@laeubi
Copy link
Member Author

laeubi commented Jun 9, 2023

@scottslewis is there maybe a snapshot/latest repos one can use for testing? Otherwise I would just wait for the next usual release of ECF.

@phermsdorf
Copy link
Contributor

@scottslewis
Copy link
Contributor

Thanks @phermsdorf for the pointer.

Our tycho-based builder is not completely up-to-date, and so the feature version updates have to be done by hand. I've done this for the bundle affected by this pr, and updated the top-level feature version to 3.14.40. It's building the snapshot now so it should be available shortly at

https://download.eclipse.org/rt/ecf/snapshot/

Here's the builder btw: https://ci.eclipse.org/ecf/job/ecf-github.master/53/ the ecf-github.master artifacts are published at snapshot/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants