Add 'duplicatesAndUnique' method to analyze haiku text characters #295 #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiveditaMishraCoding
changed the title
NiveditaMishraCoding
changed the title
Sweta716
reviewed
Sep 22, 2023
The variable names were already given. I don’t wanted to make changes on existing variables. |
Sweta716
approved these changes
Sep 22, 2023
| import org.eclipse.collections.impl.factory.SortedBags; | ||
|
|
||
| import java.util.List; |
There was a problem hiding this comment.
Why are we removing this import? Is it unused?
| .map(Character::toLowerCase) // Convert to lowercase | ||
| .collect(Collectors.groupingBy(c -> c, Collectors.counting())); | ||
|
|
||
| Map<Character, Long> duplicates = chars.entrySet().stream() |
There was a problem hiding this comment.
Can you please rename this to duplicateChars
| .filter(entry -> 1L < entry.getValue()) // Filter duplicates | ||
| .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue)); | ||
|
|
||
| Set<Character> unique = chars.entrySet().stream() |
There was a problem hiding this comment.
Same as above, please rename to uniqueChars to be specific and readable code
| @@ -41,8 +41,8 @@ public void distinctLetters() | |||
| Assertions.assertEquals("breakingthoupvmwcdflsy", distinctLetters); | |||
| } | |||
|
|
|||
| // @Test // Uncomment once duplicatesAndUnique is implemented for JDK | |||
| // @Tag("SOLUTION") | |||
| @Test // Uncomment once duplicatesAndUnique is implemented for JDK | |||
There was a problem hiding this comment.
Please remove the comment as we would not need it post the PR merge
NiveditaMishraCoding
force-pushed
the
master
branch
2 times, most recently
from
68b4a0b
to
486b8bd
Compare
rzrobin213
approved these changes
Sep 22, 2023
NiveditaMishraCoding
force-pushed
the
master
branch
from
8c83f97
to
b194084
Compare
|
Thank you @NiveditaMishraCoding for your contributions!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'duplicatesAndUnique' method to analyze haiku text characters