Upgrade CheckStyle. #1511
Merged
Upgrade CheckStyle. #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.7.0 to 10.11.0. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-10.7.0...checkstyle-10.11.0) --- updated-dependencies: - dependency-name: com.puppycrawl.tools:checkstyle dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
motlin
force-pushed
the
upgrade-checkstyle
branch
from
805ad52
to
6a9e889
Compare
nikhilnanivadekar
approved these changes
Sep 11, 2023
| @@ -246,8 +246,6 @@ | |||
|
|
|||
| <module name="SimplifyBooleanReturn" /> | |||
|
|
|||
There was a problem hiding this comment.
Being lazy here, was this removed or something changed that we dislike?
There was a problem hiding this comment.
I looked at the build failure on the dependabot review: #1510
It says You have 677 Checkstyle violations. and they are all (design) FinalClass: Class <classname> should be declared as final.
I don't know if the check was broken and they fixed it, or if they made it more strict, or what. I just disabled the check to move forward.
|
Makes sense, thanks!
…On Mon, Sep 11, 2023 at 9:54 AM Craig P. Motlin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In checkstyle-configuration.xml
<#1511 (comment)>
:
> @@ -246,8 +246,6 @@
<module name="SimplifyBooleanReturn" />
I looked at the build failure on the dependabot review: #1510
<#1510>
It says You have 677 Checkstyle violations. and they are all (design)
FinalClass: Class KeySet should be declared as final.
I don't know if the check was broken and they fixed it, or if they made it
more strict, or what. I just disabled the check to move forward.
—
Reply to this email directly, view it on GitHub
<#1511 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLY4XPJHTW7TXH7PBSODP3XZ464XANCNFSM6AAAAAA4TSEANQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.