-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding value extractors for primitive iterable types #374
Conversation
befe8af
to
3c5108b
Compare
@marko-bekhta firstly apologies for the delay in reply.
How soon do you need value extractors? This will help me prioritize the conversations for new repository creation, etc. |
Hi @nikhilnanivadekar no worries, it's fine :)
Hah, haven't seen that one. I'll make the changes and force-push the commit. As for the last question - there's no rush on my side, so whenever you have time for this, is fine for me. Also if I missed some collections - let me know, I can add extractors for those as well (either now or when the new repo is ready, depending on what works better for you) |
Signed-off-by: marko-bekhta <marko.prykladna@gmail.com>
3c5108b
to
6672a37
Compare
Hi @nikhilnanivadekar any news on this? I've fixed the license headers and in addition rebased on top of lates master changes. |
Apologies @marko-bekhta I forgot about this. I will follow up on getting a different repository for value extractors and post you. Thanks for your patience! |
hi @nikhilnanivadekar :) how's the follow up on a repository? Maybe I can help with something there ? |
I am pretty tied up at the moment. @itohiro73 can you please help take this forward? |
Hi, any news? If you can point me into the right direction I can try to get this moving forward. Thanks! |
@nikhilnanivadekar @marko-bekhta this PR is almost two years old. Should we revisit, rethink or close this? |
@donraab that's a good question 😉 I haven't seen much interest/need in these particular extractors since the time this PR was opened. Hence I'll leave it up to you to decide how you'd like to move forward with it. If any help is needed from me to bring this work up to date - just let me know. |
Apologies for the tardy reply. We have 2 options:
Both the approaches have their pros and cons.
Question to @marko-bekhta how do you foresee the extractors being used? I am not an hibernate expert so don't quite know how the value extractors will be situated and used. If you have documentation or code or blogs where I can get myself educated with this, it will help make us the decision. Appreciate your patience and support! |
Hi all,
as per http://beanvalidation.org/2.0/spec/#valueextractordefinition Bean validation 2.0 offers so called ValueExtractor mechanism to allow adding constraints for containers. I've added a couple of such extractors in a separate module for primitive iterables.
Do you think this would be a good addition for Eclipse Collections? If so - it'll be great if you can point me to other collections that are not yet included but should probably have such extractors. Looking forward for the feedback. Thanks!