Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ContentAlignment properly #688

Closed
uruuru opened this issue Aug 10, 2020 · 2 comments
Closed

Document ContentAlignment properly #688

uruuru opened this issue Aug 10, 2020 · 2 comments
Assignees
Labels
chore Comparatively mindless work that has to be done.
Milestone

Comments

@uruuru
Copy link
Contributor

uruuru commented Aug 10, 2020

For the following graph I would expect the two inner atomic nodes of n1 to be center-aligned due to the contentAlignment and the expandNodes options.

Am I interpreting the options wrongly?

image

algorithm: rectpacking

contentAlignment: "H_CENTER V_CENTER"
expandNodes: true

node n1 {
    layout [ size: 300, 100]
    label "n1"
    node i1
    node i2
}

node n2 {
    layout [ size: 50, 100]
    label "n2"
}


node n3 {
    layout [ size: 50, 100]
    label "n3"
}


node n4 {
    layout [ size: 50, 100]
    label "n4"
}

node n5 {
    layout [ size: 500, 20]
    label "n5"
}

node n6 {
    layout [ size: 500, 20]
    label "n6"
}
@soerendomroes
Copy link
Contributor

It seems to be the case that each child graph can individually decide to be aligned or not
The following produces the desired output:

algorithm: rectpacking
//contentAlignment: "H_CENTER V_CENTER"
expandNodes: true

node n1 {
    layout [ size: 300, 100]
    contentAlignment: "H_CENTER V_CENTER"
    label "n1"
    node i1
    node i2
}

node n2 {
    layout [ size: 50, 100]
    label "n2"
}


node n3 {
    layout [ size: 50, 100]
    label "n3"
}


node n4 {
    layout [ size: 50, 100]
    label "n4"
}

node n5 {
    layout [ size: 500, 20]
    label "n5"
}

node n6 {
    layout [ size: 500, 20]
    label "n6"
}

@uruuru
Copy link
Contributor Author

uruuru commented Aug 19, 2020

Ah, I see. My bad. I guess we should add that to the documentation in the melk.

@uruuru uruuru added the chore Comparatively mindless work that has to be done. label Aug 19, 2020
@uruuru uruuru added this to the Release 0.8.0 milestone Aug 19, 2020
@le-cds le-cds changed the title ContentAlignment not respected Document ContentAlignment properly Sep 16, 2020
soerendomroes added a commit to soerendomroes/elk that referenced this issue Sep 28, 2020
Signed-off-by: Soeren Domroes <sdo@informatik.uni-kiel.de>
soerendomroes added a commit to soerendomroes/elk that referenced this issue Sep 28, 2020
Signed-off-by: Soeren Domroes <sdo@informatik.uni-kiel.de>
soerendomroes added a commit to soerendomroes/elk that referenced this issue Sep 28, 2020
Signed-off-by: Soeren Domroes <sdo@informatik.uni-kiel.de>
le-cds added a commit that referenced this issue Oct 16, 2020
[PR] core: Document content alignment properly #688
@uruuru uruuru closed this as completed Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Comparatively mindless work that has to be done.
Projects
None yet
Development

No branches or pull requests

2 participants