[tracing] Remove exceptions when no traced objects #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erwan Bousse <erwan.bousse@ls2n.fr>
ebousse
force-pushed
the
fix-trace-constructor-refs
branch
from
e65aa67
to
2a81716
Compare
|
the changes look good to me and the CI is OK |
ebousse
added a commit
that referenced
this pull request
Jun 7, 2019
Signed-off-by: Erwan Bousse <erwan.bousse@ls2n.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently a change was made to throw exceptions when a reference stored in a trace cannot find a traced object as target. However, in such cases, the trace should actually simply store a reference to the original object of the executed model, and not to the traced object (eg. to point to a purely static "current state" in an FSM, while State is not a dynamic class at all and should not be).
This PR remove the exceptions and switches to the expected behavior.