Fix updating of Sirius views during debugging #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steffen Zschaler <steffen.zschaler@kcl.ac.uk>
|
I've created a test branch szschaler-fix_updating_sirius_view_during_debugging by following instructions on https://github.com/eclipse/gemoc-studio/wiki/Official-commiter-memo let's wait for the CI results (with the corresponding branch on https://ci.eclipse.org/gemoc/job/gemoc-studio-integration/) before accepting this 🙂 |
|
Thanks and apologies for not reading the documentation. Looks like the Jenkins build fails when trying to check out from the repo. Do I need to add keys or something? |
|
No, this is OK for the build, your branch was close enough to the head. The failed build was due to a previous PR that was split in 3 repositories and I forgot to accept one. It passes now. |
|
So is this ready to be merged? |
ebousse
pushed a commit
that referenced
this pull request
Jun 7, 2019
Signed-off-by: Steffen Zschaler <steffen.zschaler@kcl.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #96
Signed-off-by: Steffen Zschaler steffen.zschaler@kcl.ac.uk