Add new GenericDebugModelId for generic model presentation and breakpoint management #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This generic ModelId intends to replace the engine specific ModelId in order to simplify engine specification for engines that can share the following features: - gemoc generic model presentation (used by debug stack view, variable view) - gemoc generic breakpoint - generic source locator Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new DebugModelId that intends to be generic for most GEMOC engines.
Reminder: the DebugModelId is used by breakpoints definitions, by debug presentation (ie. debug and variable view) and source locators (ie. the service used by the debug view to retrieve the model element in the editors)
Using this central Id instead of engine specific ones will help decrease issue while defining new dsl as this id must be used by the GUI when setting the breakpoints (ie. in the breakpoint actions in the odesign, in the Sirius debugService that contributes to the debug layer of the odesign)
This PR also contributes a generic ModelPresentation and SourceLocator (currently based on the sequential engine)
Future PRs should contribute enhancement for handling other engine presentations (eg. concurrent, ...)
Important note: once an engine switches to the use of this new model id, existing launch configurations will not be valid anymore (the debugmodelId is stored in the .launch file in the user's workspaces). The users must recreate them.