Remove Logical Step View from perspective extension declaration #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this extension should not configure the position of the logicalStep view in javaengine as it is already declared in moccmlengine (where this view is defined) Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
|
Is Moccml engine the right place for this view, given that it is also used by other concurrent engines? |
|
You're right since this view can become more and more relevant (even with sequential engines when we consider external event injection, we can think about impacts on this view) However, this PR is mainly to quickly remove the duplicate inconsistent declaration from java engine(that is not the correct place too), |
|
Issue #146 created. |
dvojtise
added a commit
to eclipse/gemoc-studio-execution-java
that referenced
this pull request
Jan 14, 2020
…udio-modeldebugging#145) this extension should not configure the position of the logicalStep view in javaengine as it is already declared in moccmlengine (where this view is defined) Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The perspective extension should not configure the position of the Logical Step view
in Java Engine as it is already declared in Moccml Engine (where this view
is defined)
This double declaration (in java engine and moccml engine) was inconsistent and was creating an empty area in the workbench