[Debug/Engine] Replace MSEOccurence" with "Step" when possible #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng into debugger-replace-mse-step framework/execution_framework/plugins/org.eclipse.gemoc.executionframework.debugger/src/org/eclipse/gemoc/executionframework/debugger/GenericSequentialModelDebugger.java framework/execution_framework/plugins/org.eclipse.gemoc.executionframework.debugger/src/org/eclipse/gemoc/executionframework/debugger/OmniscientGenericSequentialModelDebugger.xtend
dvojtise
pushed a commit
to eclipse/gemoc-studio-execution-java
that referenced
this pull request
Jan 14, 2020
…se/gemoc-studio-modeldebugging#34) * [Engine/Debug] Replace use of MSEOccurrences by Steps * [Trace/Debug] Adapt multidimensional timeline to new breakpoint api Signed-off-by: Erwan Bousse erwan.bousse@tuwien.ac.at
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A significant amount of legacy code still relied on MSEOccurrence instances instead of Step instances to manage the current state of the Engine or of the Debugger. Since Steps contain more information, this PR make changes in the API and in implementations to make this switch.
This PR will facilitate the management of #32 , as we will be able to more easily know what kind of step we are dealing with at the top of the debugger stack.
Signed-off-by: Erwan Bousse erwan.bousse@tuwien.ac.at