Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use general extension point + nature and builder refactoring #185

Merged
merged 6 commits into from
Nov 22, 2019

Conversation

dvojtise
Copy link
Contributor

@dvojtise dvojtise commented Nov 19, 2019

Companion PR to eclipse/gemoc-studio-modeldebugging#133

It adapts the examples to the removal of the org.eclipse.gemoc.gemoc_language_workbench.sequential.xdsml extension point

It adapts the release engineering to the removal of org.eclipse.gemoc.execution.sequential.javaxdsml.api plugin

this plugin is now useless since all its content is covered by the
general  org.eclipse.geomc.xdsmlframework.api

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Copy link
Contributor

@ebousse ebousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
@dvojtise dvojtise changed the title Use general extension point Use general extension point + nature and builder refactoring Nov 21, 2019
@dvojtise
Copy link
Contributor Author

As discussed in eclipse/gemoc-studio-modeldebugging#133
This PR also includes nature and builder refactoring

It also contains some improvements in some helpers allowing to manipulate project configuration (in IProjectUtils and JavaProject classes)

GEMOC Sequential xDSML Project to GEMOC Java xDSML Project
GEMOC cocnurrent xDSML Project to GEMOC Moccml xDSML Project

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
@dvojtise dvojtise merged commit 5d07dfa into master Nov 22, 2019
@dvojtise dvojtise deleted the use_general_extension_point branch November 22, 2019 13:38
dvojtise added a commit to eclipse/gemoc-studio-modeldebugging that referenced this pull request Jan 15, 2020
…/gemoc-studio#185)

* remove org.eclipse.gemoc.execution.sequential.javaxdsml.api
  - this plugin is now useless since all its content is covered by the general  org.eclipse.geomc.xdsmlframework.api
* use general language EP instead of sequential in examples
* fix IProjectUtils.removeNature()
* add JavaProject.addSourceFolder() helper
* update fsm exampe to new natures and builders
* rename new project wizards: GEMOC Sequential xDSML Project to GEMOC Java xDSML Project and  GEMOC cocnurrent xDSML Project to GEMOC Moccml xDSML Project

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants