Improve Discovery error reporting in case of incorrect configuration #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, I managed to install the concurrent engine without any problem with this build, so no regression so far. |
dvojtise
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #52
This allows to have a better error reporting in case of installation failure via the discovery.
Due to API restriction, the code is not very nice and duplicates some classes from amalgam.
However a better fix has been provided directly in amalgam (https://git.eclipse.org/r/#/c/118366/ and https://bugs.eclipse.org/bugs/show_bug.cgi?id=531789 )
So this PR will have to be reverted as soon as the gerrit patch has been accepted and deployed in the official eclipse update site.