Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hawkBit::REST:Documentation: fix build with openjdk 17 #1259

Closed
wants to merge 1 commit into from

Conversation

martinetd
Copy link

hawkBit no longer built after upgrading the jvm from openjdk 11 to 17:
[ERROR] Failed to execute goal org.asciidoctor:asciidoctor-maven-plugin:1.5.2:process-asciidoc (generate-docs) on project hawkbit-rest-docs: Execution generate-docs of goal org.asciidoctor:asciidoctor-maven-plugin:1.5.2:process-asciidoc failed: (LoadError) load error: jruby/java/java_ext/java.lang -- java.lang.reflect.InaccessibleObjectException: Unable to make protected native java.lang.Object java.lang.Object.clone() throws java.lang.CloneNotSupportedException accessible: module java.base does not "opens java.lang" to unnamed module @fefbafd -> [Help 1]

Explicitely adding the jruby dependency to the asciidoctor plugin seems
to make this work, and does not break compilation with older jdk

@hawkbit-bot
Copy link

Can one of the admins verify this patch?

@martinetd
Copy link
Author

I'll update the commit with my sign-off once I've obtained permission from my employer to sign the ECA, as it apparently involves them as well.

hawkBit no longer built after upgrading the jvm from openjdk 11 to 17:
[ERROR] Failed to execute goal org.asciidoctor:asciidoctor-maven-plugin:1.5.2:process-asciidoc (generate-docs) on project hawkbit-rest-docs: Execution generate-docs of goal org.asciidoctor:asciidoctor-maven-plugin:1.5.2:process-asciidoc failed: (LoadError) load error: jruby/java/java_ext/java.lang -- java.lang.reflect.InaccessibleObjectException: Unable to make protected native java.lang.Object java.lang.Object.clone() throws java.lang.CloneNotSupportedException accessible: module java.base does not "opens java.lang" to unnamed module @fefbafd -> [Help 1]

Explicitely adding the jruby dependency to the asciidoctor plugin seems
to make this work, and does not break compilation with older jdk

Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
Copy link

@hawkbit-bot hawkbit-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinetd for taking the time to contribute to hawkBit! We really appreciate this. Make yourself comfortable while I'm looking for a committer to help you with your contribution.
Please make sure you read the contribution guide and signed the Eclipse Contributor Agreement (ECA).

@martinetd
Copy link
Author

martinetd commented Jun 14, 2022

Hmm, I just signed the ECA but the revalidation page doesn't seem to agree. I'll try a bit later assuming it might take time to propagate.
Commit message was adjusted to add sign-off line.

EDIT: ECA worked revalidating 1h later

@diegorondini
Copy link
Contributor

@laverman Why is this labeled 'wontfix'?

@diegorondini
Copy link
Contributor

@stefbehl can you have a look at this?
We got to more or less the same fix regarding the asciidoctor issue:
Kynetics@c489d80

Also, I seem to remember this doesn't affect just Java 17. Can you have a second look at this patch?

@avgustinmm
Copy link
Contributor

@martinetd,
the hawkbit already uses jdk 17 and it seems there is no problem with building javadoc.
Is the problem, this PR aims to fix, still occurring or we could close the PR as obsolete?

@avgustinmm
Copy link
Contributor

obsolete

@avgustinmm avgustinmm closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants