-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hawkBit::REST:Documentation: fix build with openjdk 17 #1259
Conversation
Can one of the admins verify this patch? |
I'll update the commit with my sign-off once I've obtained permission from my employer to sign the ECA, as it apparently involves them as well. |
hawkBit no longer built after upgrading the jvm from openjdk 11 to 17: [ERROR] Failed to execute goal org.asciidoctor:asciidoctor-maven-plugin:1.5.2:process-asciidoc (generate-docs) on project hawkbit-rest-docs: Execution generate-docs of goal org.asciidoctor:asciidoctor-maven-plugin:1.5.2:process-asciidoc failed: (LoadError) load error: jruby/java/java_ext/java.lang -- java.lang.reflect.InaccessibleObjectException: Unable to make protected native java.lang.Object java.lang.Object.clone() throws java.lang.CloneNotSupportedException accessible: module java.base does not "opens java.lang" to unnamed module @fefbafd -> [Help 1] Explicitely adding the jruby dependency to the asciidoctor plugin seems to make this work, and does not break compilation with older jdk Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martinetd for taking the time to contribute to hawkBit! We really appreciate this. Make yourself comfortable while I'm looking for a committer to help you with your contribution.
Please make sure you read the contribution guide and signed the Eclipse Contributor Agreement (ECA).
Hmm, I just signed the ECA but the revalidation page doesn't seem to agree. I'll try a bit later assuming it might take time to propagate. EDIT: ECA worked revalidating 1h later |
@laverman Why is this labeled 'wontfix'? |
@stefbehl can you have a look at this? Also, I seem to remember this doesn't affect just Java 17. Can you have a second look at this patch? |
@martinetd, |
obsolete |
hawkBit no longer built after upgrading the jvm from openjdk 11 to 17:
[ERROR] Failed to execute goal org.asciidoctor:asciidoctor-maven-plugin:1.5.2:process-asciidoc (generate-docs) on project hawkbit-rest-docs: Execution generate-docs of goal org.asciidoctor:asciidoctor-maven-plugin:1.5.2:process-asciidoc failed: (LoadError) load error: jruby/java/java_ext/java.lang -- java.lang.reflect.InaccessibleObjectException: Unable to make protected native java.lang.Object java.lang.Object.clone() throws java.lang.CloneNotSupportedException accessible: module java.base does not "opens java.lang" to unnamed module @fefbafd -> [Help 1]
Explicitely adding the jruby dependency to the asciidoctor plugin seems
to make this work, and does not break compilation with older jdk