Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elements in output compound datasets not reset #187

Open
PeterC-DLS opened this issue May 11, 2017 · 2 comments
Open

Elements in output compound datasets not reset #187

PeterC-DLS opened this issue May 11, 2017 · 2 comments

Comments

@PeterC-DLS
Copy link
Contributor

When an output compound dataset is given, not all its elements are set to zero.

This bug found in #184 and fixed in #186 applies to many other methods in Maths (and may be other classes too).
@PierreSachot
Copy link
Contributor

Dear Peter,

Do you want me to fix that or will you fix it ? Because I watched inside Maths.java class and in Complex cases there is no others cases like abs one.

@PeterC-DLS
Copy link
Contributor Author

I have merged the (partial) fix in #186 so please rebase your PR #184 on master. A complete fix for other methods will be tracked by this issue.

PeterC-DLS added a commit that referenced this issue May 17, 2017
@PeterC-DLS
Fix compound dataset handling in Maths methods
5c39d8c 
Part fix for #187, expand broadcasting to allow output to have a single element per item, and tests
@PeterC-DLS PeterC-DLS mentioned this issue May 17, 2017
Merged
PeterC-DLS added a commit that referenced this issue May 17, 2017
@PeterC-DLS
Fix compound dataset handling in Maths methods (#192)
91db7af 
Part fix for #187, expand broadcasting to allow output to have a single element per item, and tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PeterC-DLS @PierreSachot