refactor: remove multiple method calls when test exceptions

Signed-off-by: Maximillian Arruda <maximillian.arruda@MBP-de-Digibee.local>
eclipse · Nov 13, 2023 · ef3e720 · ef3e720
1 parent 0cdf402
commit ef3e720
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/.../java/org/eclipse/jnosql/databases/mongodb/communication/MongoDBSpecificFeaturesTest.java b/.../java/org/eclipse/jnosql/databases/mongodb/communication/MongoDBSpecificFeaturesTest.java
@@ -64,13 +64,14 @@ void beforeEach() {
 
     @Test
     void shouldReturnErrorOnSelectWhenThereIsNullParameter() {
+        Bson filter = eq("name", "Poliana");
+
         Assertions.assertThrows(NullPointerException.class,
                 () -> entityManager.select(null, null));
         Assertions.assertThrows(NullPointerException.class,
                 () -> entityManager.select(COLLECTION_NAME, null));
-
         Assertions.assertThrows(NullPointerException.class,
-                () -> entityManager.select(null, eq("name", "Poliana")));
+                () -> entityManager.select(null, filter));
     }
 
     @Test
@@ -85,6 +86,8 @@ void shouldFindDocument() {
 
     @Test
     void shouldReturnErrorOnDeleteWhenThereIsNullParameter() {
+        Bson filter = eq("name", "Poliana");
+
         Assertions.assertThrows(NullPointerException.class,
                 () -> entityManager.delete(null, null));
         Assertions.assertThrows(NullPointerException.class,
@@ -108,6 +111,10 @@ void shouldDelete() {
 
     @Test
     void shouldReturnErrorOnAggregateWhenThereIsNullParameter() {
+        Bson bson = eq("name", "Poliana");
+        List<Bson> pipeline = Collections.singletonList(bson);
+        var pipelineArray = new Bson[]{bson};
+
         Assertions.assertThrows(NullPointerException.class,
                 () -> entityManager.aggregate(null, (List<Bson>) null));
         Assertions.assertThrows(NullPointerException.class,
@@ -178,12 +185,14 @@ void shouldCountWithFilter() {
     @Test
     void shouldReturnErrorOnCountWithInvalidFilter() {
 
+        Bson filter = eq("name", "Poliana");
+
         Assertions.assertThrows(NullPointerException.class,
                 () -> entityManager.count(null, null));
         Assertions.assertThrows(NullPointerException.class,
                 () -> entityManager.count(COLLECTION_NAME, null));
         Assertions.assertThrows(NullPointerException.class,
-                () -> entityManager.count(null, eq("name","Poliana")));
+                () -> entityManager.count(null, filter));
 
     }