feat: create condition to Find annotation and OrderBy

Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
eclipse · Apr 1, 2024 · 9572b7b · 9572b7b
1 parent b66bc93
commit 9572b7b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/...osql-mapping-core/src/main/java/org/eclipse/jnosql/mapping/core/query/RepositoryType.java b/...osql-mapping-core/src/main/java/org/eclipse/jnosql/mapping/core/query/RepositoryType.java
@@ -152,7 +152,7 @@ public static RepositoryType of(Method method, Class<?> repositoryType) {
             return DEFAULT;
         }
         if (method.getAnnotationsByType(OrderBy.class).length > 0) {
-            return ORDER_BY;
+            return method.getAnnotation(Find.class) == null? ORDER_BY: PARAMETER_BASED;
         }
         if (!repositoryType.equals(declaringClass) && isCustomRepository(declaringClass)) {
             return CUSTOM_REPOSITORY;

diff --git a/...-mapping-core/src/test/java/org/eclipse/jnosql/mapping/core/query/RepositoryTypeTest.java b/...-mapping-core/src/test/java/org/eclipse/jnosql/mapping/core/query/RepositoryTypeTest.java
@@ -127,6 +127,12 @@ void shouldReturnParameterBased() throws NoSuchMethodException {
         Assertions.assertEquals(RepositoryType.PARAMETER_BASED, RepositoryType.of(getMethod(DevRepository.class, "find"), CrudRepository.class));
     }
 
+    @Test
+    void shouldReturnParameterBased2() throws NoSuchMethodException {
+        Assertions.assertEquals(RepositoryType.PARAMETER_BASED, RepositoryType.of(getMethod(DevRepository.class, "find2"), CrudRepository.class));
+    }
+
+
     @Test
     void shouldReturnCountBy() throws NoSuchMethodException {
         Assertions.assertEquals(RepositoryType.COUNT_BY, RepositoryType.of(getMethod(DevRepository.class, "countByName"), CrudRepository.class));
@@ -246,6 +252,9 @@ default int duplicate(int value) {
         @Find
         List<String> find(String name);
 
+        @Find
+        @OrderBy("name")
+        List<String> find2(String name);
         CursoredPage<String> findByNameOrderByName(String name, PageRequest<String> pageable);
 
     }