Skip to content

Commit

Permalink
refac: update constructor using record style
Browse files Browse the repository at this point in the history
Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
  • Loading branch information
otaviojava committed Jul 30, 2023
1 parent 282aa76 commit d77acde
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ private ConstructorBuilder(ConstructorMetadata metadata) {


public List<ParameterMetaData> getParameters() {
return this.metadata.getParameters();
return this.metadata.parameters();
}

public void add(Object value) {
Expand All @@ -54,7 +54,7 @@ public void addEmptyParameter() {
}

public <T> T build() {
Constructor<?> constructor = metadata.getConstructor();
Constructor<?> constructor = metadata.constructor();

try {
Instance<Event<ConstructorEvent>> instance = CDI.current().select(new TypeLiteral<>() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ public final class ConstructorMetadata {
this.parameters = parameters;
}

public List<ParameterMetaData> getParameters() {
public List<ParameterMetaData> parameters() {
return parameters;
}

public Constructor<?> getConstructor() {
public Constructor<?> constructor() {
return constructor;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ public void shouldCreateEntityMetadataWithConstructor() {
ConstructorMetadata constructor = entityMetadata.constructor();
assertNotNull(constructor);
assertFalse(constructor.isDefault());
assertEquals(5, constructor.getParameters().size());
assertEquals(5, constructor.parameters().size());
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -56,20 +56,20 @@ public void setUp() {
public void shouldReturnEmptyMetadata() {
ConstructorMetadata metadata = builder.build(Person.class);
Assertions.assertNotNull(metadata);
Assertions.assertTrue(metadata.getParameters().isEmpty());
Assertions.assertTrue(metadata.parameters().isEmpty());
}

@Test
public void shouldReturnEmptyDefaultConstructor() {
ConstructorMetadata metadata = builder.build(Worker.class);
Assertions.assertNotNull(metadata);
Assertions.assertTrue(metadata.getParameters().isEmpty());
Assertions.assertTrue(metadata.parameters().isEmpty());
}

@Test
public void shouldReturnComputerEntityConstructor() {
ConstructorMetadata metadata = builder.build(Computer.class);
List<ParameterMetaData> parameters = metadata.getParameters();
List<ParameterMetaData> parameters = metadata.parameters();
assertEquals(5, parameters.size());
List<String> names = parameters.stream()
.map(ParameterMetaData::name)
Expand All @@ -81,7 +81,7 @@ public void shouldReturnComputerEntityConstructor() {
@Test
public void shouldReturnBookUserEntityConstructor() {
ConstructorMetadata metadata = builder.build(BookUser.class);
List<ParameterMetaData> parameters = metadata.getParameters();
List<ParameterMetaData> parameters = metadata.parameters();
assertEquals(3, parameters.size());
List<String> names = parameters.stream()
.map(ParameterMetaData::name)
Expand All @@ -93,7 +93,7 @@ public void shouldReturnBookUserEntityConstructor() {
@Test
public void shouldReturnSmartphoneEntityConstructor() {
ConstructorMetadata metadata = builder.build(Smartphone.class);
List<ParameterMetaData> parameters = metadata.getParameters();
List<ParameterMetaData> parameters = metadata.parameters();
assertEquals(2, parameters.size());
List<String> names = parameters.stream()
.map(ParameterMetaData::name)
Expand All @@ -105,7 +105,7 @@ public void shouldReturnSmartphoneEntityConstructor() {
@Test
public void shouldReturnPetOwnerEntityConstructor() {
ConstructorMetadata metadata = builder.build(PetOwner.class);
List<ParameterMetaData> parameters = metadata.getParameters();
List<ParameterMetaData> parameters = metadata.parameters();
assertEquals(3, parameters.size());
List<String> names = parameters.stream()
.map(ParameterMetaData::name)
Expand Down

0 comments on commit d77acde

Please sign in to comment.