Add code action participant #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrubezhny
force-pushed
the
addCodeActions
branch
2 times, most recently
from
e4f1aa8
to
bb25093
Compare
...eclipse/lemminx/extensions/maven/participants/codeaction/MavenCodeActionParticipantTest.java
Outdated
Show resolved
Hide resolved
...eclipse/lemminx/extensions/maven/participants/codeaction/MavenCodeActionParticipantTest.java
Outdated
Show resolved
Hide resolved
...org/eclipse/lemminx/extensions/maven/participants/codeaction/MavenCodeActionParticipant.java
Outdated
Show resolved
Hide resolved
vrubezhny
force-pushed
the
addCodeActions
branch
from
bb25093
to
7c35175
Compare
vrubezhny
added a commit
to vrubezhny/lemminx-maven
that referenced
this pull request
Feb 18, 2023
This PR adds Maven project validation for groupId/version element values duplicating the parent groupId/version element values Also this adds Code Actions for the removal of the duplicating groupId/version elements and according JUnit test cases Depends on eclipse#362
vrubezhny
force-pushed
the
addCodeActions
branch
from
7c35175
to
f33a9f6
Compare
vrubezhny
added a commit
to vrubezhny/lemminx-maven
that referenced
this pull request
Feb 18, 2023
This PR adds Maven project validation for groupId/version element values duplicating the parent groupId/version element values Also this adds Code Actions for the removal of the duplicating groupId/version elements and according JUnit test cases Depends on eclipse#362
mickaelistria
requested changes
Feb 20, 2023
...org/eclipse/lemminx/extensions/maven/participants/codeaction/MavenCodeActionParticipant.java
Outdated
Show resolved
Hide resolved
vrubezhny
force-pushed
the
addCodeActions
branch
from
f33a9f6
to
466626e
Compare
lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/MavenLemminxExtension.java
Outdated
Show resolved
Hide resolved
vrubezhny
force-pushed
the
addCodeActions
branch
2 times, most recently
from
d00290c
to
4a2c432
Compare
lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/MavenLemminxExtension.java
Outdated
Show resolved
Hide resolved
lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/MavenLemminxExtension.java
Outdated
Show resolved
Hide resolved
vrubezhny
force-pushed
the
addCodeActions
branch
2 times, most recently
from
b3ced8b
to
4b588dc
Compare
lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/MavenLemminxExtension.java
Outdated
Show resolved
Hide resolved
This PR adds Code Action participants registration, NoGrammarConstraints Code Action with an according JUnit test
vrubezhny
force-pushed
the
addCodeActions
branch
from
4b588dc
to
eceb432
Compare
mickaelistria
approved these changes
Feb 21, 2023
vrubezhny
added a commit
to vrubezhny/lemminx-maven
that referenced
this pull request
Feb 21, 2023
This PR adds Maven project validation for groupId/version element values duplicating the parent groupId/version element values Also this adds Code Actions for the removal of the duplicating groupId/version elements and according JUnit test cases Depends on eclipse#362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.