Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover Participant - Cancel any operation as soon as possible. #397

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

vrubezhny
Copy link
Contributor

Issue: #358

@angelozerr
Copy link
Contributor

I'm glad @vrubezhny that you use this cancel support, but have you checked it is working with LSP4E?

I know that @mickaelistria has done something about this cancel support on LSP client side for hover, but it could be nice to check it is working with LSP4E by debugging the lemminx maven extension.

@vrubezhny
Copy link
Contributor Author

@angelozerr Thanks for the info.
The JUnit tests pass well, so the cancellation support doesn't bring any visible problems. but I'll try finding out what @mickaelistria has done on LSP client side and try debugging the extension.

@mickaelistria
Copy link
Contributor

Cancellation is not yet supported in LSP4E, it got better but not yet complete. So at the moment, there is not even 1 client of lemminx-maven that supports cancellation, I suggest we just ignore it for the moment, until we can benefit from it on client side.

@angelozerr
Copy link
Contributor

Vscode support cancel support

@mickaelistria
Copy link
Contributor

Vscode support cancel support

As far as I know, lemminx-maven is not yet supported in VSCode, is it?

@vrubezhny
Copy link
Contributor Author

Once the cancellation is not fully supported in LSP4E, I can suggest a simple tests on LemMinX-Maven side, like handling an immediate cancellation that mostly check that the cancelling itself doesn't bring any problems.
Later we can probably add some more testing.

@mickaelistria
Copy link
Contributor

Automated test would be great!

@vrubezhny vrubezhny force-pushed the fixHandleCancellingInHovers branch 3 times, most recently from b7de7bc to e96a9d5 Compare April 28, 2023 17:30
@vrubezhny vrubezhny merged commit e5bcb94 into eclipse:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants