Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folding annotations gets removed on large files while editing #934

Closed
ghentschke opened this issue Feb 28, 2024 · 0 comments · Fixed by #935
Closed

Folding annotations gets removed on large files while editing #934

ghentschke opened this issue Feb 28, 2024 · 0 comments · Fixed by #935
Assignees
@ghentschke

Comments

@ghentschke
Copy link
Contributor

When opening a large file with in a LSP backed generic text editor (e.g. C file with clangd) and starting to edit this file, the folding annotations will be removed:

image
ghentschke added a commit to ghentschke/lsp4e-bachmann-fixes that referenced this issue Feb 28, 2024
@ghentschke
[eclipse#934] fix removed folding annotations on document change
4e347af 
The method
org.eclipse.jface.text.source.projection.ProjectionAnnotationModel.modifyAnnotations(Annotation[],
Map<? extends Annotation, ? extends Position>, Annotation[]) does not
consider Position changes in any cases. On large annotations the
positions won't get updated properly which leads to removed folding
annotations.
ghentschke added a commit to ghentschke/lsp4e-bachmann-fixes that referenced this issue Feb 28, 2024
@ghentschke
[eclipse#934] fix removed folding annotations on document change
da88ce5 
The method
ProjectionAnnotationModel.modifyAnnotations(Annotation[],
Map<? extends Annotation, ? extends Position>, Annotation[]) does not
consider Position changes in any cases. On large annotations the
positions won't get updated properly which leads to removed folding
annotations.

fixes eclipse#934
@ghentschke ghentschke mentioned this issue Feb 28, 2024
Merged
@ghentschke ghentschke self-assigned this Feb 28, 2024
ghentschke added a commit that referenced this issue Mar 4, 2024
@ghentschke
[#934] fix removed folding annotations on document change
0beab27 
The method
ProjectionAnnotationModel.modifyAnnotations(Annotation[],
Map<? extends Annotation, ? extends Position>, Annotation[]) does not
consider Position changes in any cases. On large annotations the
positions won't get updated properly which leads to removed folding
annotations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghentschke ghentschke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#934] fix removed folding annotations on document change ghentschke/lsp4e-bachmann-fixes
1 participant
@ghentschke