Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handlers: Use activeWhen rather than enabledWhen consistently and scope #149

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

mickaelistria
Copy link
Contributor

to languageServer

@mickaelistria mickaelistria merged commit cad85f9 into eclipse:master Jun 13, 2022
@mickaelistria
Copy link
Contributor Author

Thanks!

@ahmedneilhussain
Copy link
Contributor

Thanks for rebasing, and sorry you had to give up waiting for me to do it and do it yourself! I had a few other bits and pieces I was entangled with for a couple of days...
I will rebase the test clean-up PR in a day or so hopefully to remove the bits that have been cherry-picked and then we can see which bits of the rest are controversial.

@mickaelistria
Copy link
Contributor Author

Thanks for rebasing, and sorry you had to give up waiting for me to do it and do it yourself!

No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants