Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BadLocationException for length==-1 #356

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Fix BadLocationException for length==-1 #356

merged 1 commit into from
Jan 12, 2023

Conversation

BoykoAlex
Copy link
Contributor

Fix #355
org.eclipse.jface.text.quickassist.QuickAssistAssistant line 71 creates TextInvocationContext with length equal to -1 - therefore length -1 is valid.
Now LSP4E just adds length to get the last position. Need to account for negative length,

@mickaelistria mickaelistria merged commit 992993f into eclipse:master Jan 12, 2023
@mickaelistria
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BadLocationException invoking quick proposals at 0,0 location.
2 participants
@BoykoAlex @mickaelistria