Cannot open any css file with the generic editor #752 #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrubezhny
force-pushed
the
fixNPEsInCNFOutlinePage
branch
from
ac5c03b
to
ec1ffef
Compare
akurtakov
reviewed
Aug 10, 2023
| uri = new URI(docIdentifier.getUri()); | ||
| } catch (URISyntaxException e) { | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Catching Exception is really bad style. As this PR is about fixing NPE couldn't you keep the original exception and do an extra null check.
There was a problem hiding this comment.
Added a null-check for document URI and restored catching original URISyntaxException
vrubezhny
force-pushed
the
fixNPEsInCNFOutlinePage
branch
from
ec1ffef
to
5cf318f
Compare
sebthom
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #752