let LSJavaCompletionProposal implement extension interface to enable linked editing mode #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…linked editing mode to work Change-Id: I11755f126f9d851b316680a4ca4342fcd6bce36f
Change-Id: I7b3a7524bdaffe1bb46482d03b1be534eccfbae1
|
@martinlippert I don't use the LSP4E/JDT bindings, and AFAIK, it's not part of some stack I'm supposed to support for my employer. So I don't think I'll even try to review here; I trust you're doing the best thing as you're more expert than me on this particular area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepting a language server completion proposal that is defined as a snippet in the Java source editor does not trigger the linked editing mode.
The problem is that the implementation of the
LSJavaCompletionProposalis somewhat limited and doesn't implement theICompletionProposalExtension2yet, so that the completion proposal doesn't get all the necessary information for entering the linked editing mode.This PR adds the necessary implementation of
ICompletionProposalExtension2to theLSJavaCompletionProposaland the linked editing mode is triggered nicely when inside the Java source file editor.