Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dcterms:title and dcterms:description to the ResourceShape class #198

Closed
jadelkhoury opened this issue Aug 31, 2021 · 5 comments · Fixed by #204
Closed

add dcterms:title and dcterms:description to the ResourceShape class #198

jadelkhoury opened this issue Aug 31, 2021 · 5 comments · Fixed by #204
Assignees
@jadelkhoury

Comments

@jadelkhoury
Copy link
Contributor

OSLC Resource Shapes are described using dcterms:title and dcterms:description. For example, see ChangeNoticeShape under https://docs.oasis-open-projects.org/oslc-op/cm/v3.0/os/change-mgt-shapes.ttl

But these 2 properties are not exposed in the java model for shapes.
https://github.com/eclipse/lyo/blob/master/core/oslc4j-core/src/main/java/org/eclipse/lyo/oslc4j/core/model/ResourceShape.java

Add these 2 properties to the model.
@jadelkhoury jadelkhoury self-assigned this Aug 31, 2021
@jadelkhoury
Copy link
Contributor Author

@jadelkhoury @jamsden !
This seems obvious to me, and would need to fix it soon. Unless you see that I am missing something?

@jadelkhoury jadelkhoury mentioned this issue Aug 31, 2021
Closed
@jamsden
Copy link
Contributor

jamsden commented Aug 31, 2021

These properties aren't inherited somehow?

@jadelkhoury
Copy link
Contributor Author

Nop! Check the code above. The Shape class inherits from AbstractResource, and that doesn't have such properties either.

@jadelkhoury
Copy link
Contributor Author

Could it be that dcterms:title and dcterms:description were not actually part of the Shape definition before? Could it be a recent addition?

jadelkhoury added a commit that referenced this issue Sep 24, 2021
@jadelkhoury
closes #198
5fa06ae 
add oslc:name and dcterms:description to the ResourceShape class.
Also adding "description" to the Shape annotations in order to be able
to construct resourceshape instances from information in the
annotations.
@jadelkhoury
Copy link
Contributor Author

jadelkhoury commented Sep 24, 2021 •
edited
Loading

Correction: The Shape class already contains the Title property. It is however missing the name & Description properties.
Resource Shape classes are normally annotated with OslcName, but this annotation is not captured in the instance of REsourceShape. We need an attribute to be able to capture the annotation information

@jadelkhoury jadelkhoury mentioned this issue Sep 24, 2021
Merged
3 tasks
jadelkhoury added a commit that referenced this issue Sep 25, 2021
@jadelkhoury
closes #198 (#204)
d2f6118 
add oslc:name and dcterms:description to the ResourceShape class.
Also adding "description" to the Shape annotations in order to be able
to construct resourceshape instances from information in the
annotations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jadelkhoury jadelkhoury

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add oslc:name and dcterms:description to the ResourceShape class eclipse/lyo
2 participants
@jamsden @jadelkhoury