Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add oslc:name and dcterms:description to the ResourceShape class #204

Merged
merged 1 commit into from
Sep 25, 2021
Merged

add oslc:name and dcterms:description to the ResourceShape class #204

merged 1 commit into from
Sep 25, 2021

Conversation

jadelkhoury
Copy link
Contributor

Description

add oslc:name and dcterms:description to the ResourceShape class.
Also adding "description" to the Shape annotations in order to be able
to construct resourceshape instances from information in the
annotations.

Checklist

  • This PR adds an entry to the CHANGELOG. See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
  • This PR was tested on at least one Lyo OSLC server or adds unit/integration tests.
  • This PR does NOT break the API

Issues

closes #198

@jadelkhoury
closes #198
5fa06ae 
add oslc:name and dcterms:description to the ResourceShape class.
Also adding "description" to the Shape annotations in order to be able
to construct resourceshape instances from information in the
annotations.
@jadelkhoury jadelkhoury self-assigned this Sep 24, 2021
@jadelkhoury jadelkhoury mentioned this pull request Sep 24, 2021
Merged
berezovskyi
berezovskyi requested changes Sep 24, 2021
View reviewed changes
Copy link
Member

@berezovskyi berezovskyi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Could you please add a line to the changelog?

@jadelkhoury
Copy link
Contributor Author

I did. But hopefully in the right place?
image

@jadelkhoury jadelkhoury merged commit d2f6118 into master Sep 25, 2021
@berezovskyi
Copy link
Member

Ah, you did that on master.

@berezovskyi berezovskyi deleted the resourceShape branch September 25, 2021 09:42
@jadelkhoury
Copy link
Contributor Author

that is right. i didn't think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berezovskyi berezovskyi berezovskyi requested changes

@jamsden jamsden Awaiting requested review from jamsden

Assignees

@jadelkhoury jadelkhoury

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add dcterms:title and dcterms:description to the ResourceShape class
2 participants
@jadelkhoury @berezovskyi