Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Lyo Store for use in the persistent scenario #81

Merged
merged 5 commits into from
Jun 7, 2021

Conversation

berezovskyi
Copy link
Member

@berezovskyi berezovskyi commented Mar 12, 2021

Description

  • Allows the Store to be close()'d and the QueryExecutor to release() its connection to the SPARQL engine.
  • (minor) stops internal use of GraphStore which is dropped in newer Jena versions

Checklist

  • This PR adds an entry to the CHANGELOG. See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
  • This PR was tested on at least one Lyo OSLC server or adds unit/integration tests.
  • This PR does NOT break the API. API is extended in this PR.

WIP the client module fails the build due to kotlin/javadoc issues.

  • Fix the TRS client build here or in another PR
  • Remove irrelevant perf and TDB2 test code from SparqlStoreImplTest.java

@berezovskyi
Copy link
Member Author

The PR not ready for merge yet but if you ignore a commented out module in the POM and a few irrelevent test cases, the code is ready for your review @jadelkhoury @jamsden

@berezovskyi
Copy link
Member Author

@berezovskyi berezovskyi marked this pull request as ready for review June 5, 2021 23:42
@berezovskyi berezovskyi force-pushed the b-store-updates branch 3 times, most recently from 211cbb9 to 3f97884 Compare June 5, 2021 23:55
@berezovskyi
Copy link
Member Author

@jadelkhoury ready for your review

@berezovskyi berezovskyi merged commit c9a326f into master Jun 7, 2021
@berezovskyi berezovskyi deleted the b-store-updates branch June 7, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants