Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Bases with rdf:nil or null next pages #102

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Allow Bases with rdf:nil or null next pages #102

merged 4 commits into from
Jun 7, 2021

Conversation

berezovskyi
Copy link
Member

Description

  • Fix a few issues around rdf:nil handling
    • Allow Bases with rdf:nil or null next pages
    • Do not fetch rdf:nil resource of a ChangeLog
  • Remove Kotlin dependency from TRS client (only one trivial Kotlin class was added)

Checklist

  • This PR adds an entry to the CHANGELOG. See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
  • This PR was tested on at least one Lyo OSLC server or adds unit/integration tests.
  • This PR does NOT break the API

Issues

Closes #89; Closes #90; Closes #91

@berezovskyi
Copy link
Member Author

@jadelkhoury ready for your review. I split these commits from the old PR #81 to make review simpler.

jadelkhoury
jadelkhoury approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@jadelkhoury jadelkhoury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on this

@berezovskyi berezovskyi merged commit 37147dc into master Jun 7, 2021
@berezovskyi berezovskyi deleted the b-trs-fixes branch June 7, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadelkhoury jadelkhoury jadelkhoury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@berezovskyi @jadelkhoury