Empty value handling - rebase from #541 #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emily-Jiang
changed the title
|
I will update the tests and accommodate the comments in my next commit. |
Emily-Jiang
changed the title
|
@radcortez @jbee please review |
Emily-Jiang
force-pushed
the
dmlloyd-empty-values
branch
from
07918f6
to
d254277
Compare
…tion Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
Emily-Jiang
force-pushed
the
dmlloyd-empty-values
branch
from
e76f97d
to
99d03be
Compare
jbee
reviewed
Sep 16, 2020
There was a problem hiding this comment.
Dropped some thoughts. The only crucial one to me is the question of how converters behave when they are given null or empty/blank string values.
I'd think
- either a not present source lookup is never passed to the converter level and doing so manually is considered undefined behaviour to lift the burden of implementing these corner cases
- or any result from source lookup is passed to the converters but any empty value (not present) results in the same behaviour as the
ConfigAPI would show, throwing an exception of some type.
api/src/main/java/org/eclipse/microprofile/config/spi/Converter.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/microprofile/config/tck/EmptyValue/EmptyValuesTestProgrammaticLookup.java
Outdated
Show resolved
Hide resolved
radcortez
requested changes
Sep 16, 2020
api/src/main/java/org/eclipse/microprofile/config/spi/Converter.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/eclipse/microprofile/config/spi/Converter.java
Outdated
Show resolved
Hide resolved
|
@Emily-Jiang I believe you have not yet pushed what you commented as done |
Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
jbee
approved these changes
Sep 17, 2020
tck/src/main/java/org/eclipse/microprofile/config/tck/EmptyValue/EmptyValuesTest.java
Outdated
Show resolved
Hide resolved
|
@radcortez I think I addressed all of your comments as well. Please take another look at it and I would like to merge in tomorrow. |
radcortez
requested changes
Sep 18, 2020
tck/src/main/java/org/eclipse/microprofile/config/tck/EmptyValue/EmptyValuesTest.java
Outdated
Show resolved
Hide resolved
radcortez
requested changes
Sep 18, 2020
...n/java/org/eclipse/microprofile/config/tck/EmptyValue/EmptyValuesTestProgrammaticLookup.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/microprofile/config/tck/EmptyValue/EmptyValuesTestProgrammaticLookup.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/config/tck/EmptyValue/EmptyValuesTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
Signed-off-by: Emily Jiang <emijiang6@googlemail.com>
tevans78
reviewed
Sep 21, 2020
...n/java/org/eclipse/microprofile/config/tck/emptyvalue/EmptyValuesTestProgrammaticLookup.java
Outdated
Show resolved
Hide resolved
radcortez
requested changes
Sep 21, 2020
...n/java/org/eclipse/microprofile/config/tck/emptyvalue/EmptyValuesTestProgrammaticLookup.java
Outdated
Show resolved
Hide resolved
This was referenced Sep 21, 2020
… into dmlloyd-empty-values
radcortez
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Emily Jiang emijiang6@googlemail.com
Fixes #446, Fixes #531, Fixes #532, Fixes #397.