Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark transaction for rollback only after rejection of parallel use #157

Merged

Conversation

njr-11
Copy link
Contributor

@njr-11 njr-11 commented Apr 15, 2019

pull fixes #156

@njr-11 njr-11 self-assigned this Apr 15, 2019
@njr-11 njr-11 requested a review from mmusgrov April 15, 2019 13:45
Copy link
Contributor

@mmusgrov mmusgrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but was there a particular reason why the tests don't always call rollback for the finally step.

@njr-11
Copy link
Contributor Author

njr-11 commented Apr 15, 2019

Changes look good but was there a particular reason why the tests don't always call rollback for the finally step.

No reason that I know of. It would certainly be valid to do that, and a bit simpler because we wouldn't need it to track whether or not the attempt to run in parallel was rejected. Would you prefer that I change it to that?

@mmusgrov
Copy link
Contributor

No need to make any changes to the PR, it was just a query and you have answered it, thanks.

@njr-11 njr-11 merged commit f495b91 into eclipse:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCK test expects transaction commit after rejection of parallel use
2 participants