Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

work around mpconfig dropping support for empty array #198

Merged
merged 1 commit into from
Sep 29, 2020
Merged

work around mpconfig dropping support for empty array #198

merged 1 commit into from
Sep 29, 2020

Conversation

njr-11
Copy link
Contributor

@njr-11 njr-11 commented Sep 25, 2020 •
edited
Loading

contains most of the fix for #160

@njr-11 njr-11 self-assigned this Sep 25, 2020
@njr-11 njr-11 mentioned this pull request Sep 25, 2020
Closed
Emily-Jiang
Emily-Jiang approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@njr-11 njr-11 mentioned this pull request Sep 28, 2020
Merged
manovotn
manovotn approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, was on PTO.
This is fine with me.

FroMage
FroMage approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we forbid ThreadContextProvider with the name None to be extra sure we'll never run into issues? I guess MP config will always filter them out, but still…

@manovotn manovotn mentioned this pull request Sep 29, 2020
Merged
@njr-11
Copy link
Contributor Author

njr-11 commented Sep 29, 2020 •
edited
Loading

LGTM, but should we forbid ThreadContextProvider with the name None to be extra sure we'll never run into issues? I guess MP config will always filter them out, but still…

It seems extremely unlikely that anyone would name their ThreadContextProvider "None", but it's easy enough to explicitly forbid that so we might as well. I'll add it in a separate pull, #199 , under the same issue given that there are already 3 approvals on this one.

@njr-11 njr-11 merged commit d9a4d0c into eclipse:master Sep 29, 2020
@njr-11 njr-11 mentioned this pull request Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

@manovotn manovotn manovotn approved these changes

@Emily-Jiang Emily-Jiang Emily-Jiang approved these changes

Assignees

@njr-11 njr-11

Labels
None yet
Projects
None yet
Milestone
MicroProfile Context Propagation 1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@njr-11 @FroMage @manovotn @Emily-Jiang