Small fixes for Async with CompletionStage #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by:Ondrej Mihalyi <ondrej.mihalyi@payara.fish>
Signed-off-by:Ondrej Mihalyi <ondrej.mihalyi@payara.fish>
Signed-off-by:Ondrej Mihalyi <ondrej.mihalyi@payara.fish>
- removed the CompletedFuture class from the Asynchronous annotation - added a CF helper to the TCK - fix for calls of stage.toCompletableFuture which may not always be implemented - fixes in Javadocs Signed-off-by:Ondrej Mihalyi <ondrej.mihalyi@payara.fish>
Signed-off-by:Ondrej Mihalyi <ondrej.mihalyi@payara.fish>
Replace isCompleted checks with completesQuickly checks to avoid a race condition where asynchronous tasks may not complete immediately, but should complete very quickly. Also include the original exception as the cause when raising an AssertionError in response to a CompletionException. Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
Clean up the language around the behaviour when a class is annotated with Asynchronous. Clarify when the FaultToleranceDefinitionException is thrown. Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
Ensure that a DefinitionException is thrown if an invalid Asynchronous method is deployed. Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
Include the CompletableFutureHelper in the test application Separate the future that we complete from the one that the user's method returns. Otherwise we set up a thenApply to get a new CompletionStage, then we manually complete that new stage which means the thenApply never runs. We need to complete the original CompletionStage instead. Assert properly on exceptions thrown from future.get(). Need to assert that an ExecutionException is thrown and that the cause is the exception thrown from the user's method. Avoid calling waitUntilCompleted after asserting that future.get() throws an exception. We don't need to wait at this point because calling get() will wait for it to finish, and the waitUntilCompleted method will always fail because we know the future completed exceptionally.
All methods in a class annotated with @asynchronous must return either Future or CompletionStage.
Based on feedback on the 2018-8-15 call. Signed-off-by: Andrew Rouse <anrouse@uk.ibm.com>
Azquelt
force-pushed
the
issue110-async-with-cs
branch
from
4a2ac88
to
d477741
Compare
|
@Emily-Jiang Did review on this PR and the previous #267. It looks good. |
|
As discussed on our hangout last week and this week, I will merge this as I have done 1.1.2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes on top of #267 in response to issues raised in that PR.
Note that at the moment, this PR includes everything in #267. If #267 is merged, I'll rebase this so it only includes my changes.