Tolerate both MP Metrics 4.0 and 5.0 APIs #611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Methods removed from Snapshot
- Gauge<T> changed to Gauge<T extends Number>
- Breaks binary compatibility because method signatures are different
after type erasure
No longer needed since we now require MP Metrics 4.0
Reflection was for compatibility between MP Metrics 2 and 3 and is no longer needed.
Azquelt
force-pushed
the
mpMetrics-5.0-both
branch
from
3396591
to
93ce8d3
Compare
|
For some reason the github action builds are not using the latest commit. I'll force push again to see if that fixes it. |
MP Metrics 5.0 uses RegistryScope instead of RegistryType to inject the MetricRegistry for a particular metrics scope. Add a BaseRegistry qualifier and create a different provider for the v4 and v5 metrics APIs. Some code needs to be compiled against the Metrics 5.0 API, so separate that out into a separate module. The common code is in the 5.0 module so that it doesn't have a dependency on the rest of the TCK so that it can be built before the TCK and its classes included in the TCK jar. The version of MP Metrics API in use is detected based on the presence of the RegistryScope annotation, or can be overridden by setting a system property.
Azquelt
force-pushed
the
mpMetrics-5.0-both
branch
from
93ce8d3
to
0c22635
Compare
|
MP Metrics 5.0 is going to deprecate and retain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tolerate the following breaking changes in MP Metrics 5.0, while retaining support for MP Metrics 4.0:
SnapshotGauge<T>changed toGauge<T extends Number>after type erasure
MetricsRegistryinjected with@RegistryScopeinstead of@RegistryType