Tolerate MP Metrics 5.0 API changes, except MetricsRegistry injection #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Methods removed from Snapshot
- Gauge<T> changed to Gauge<T extends Number>
- Breaks binary compatibility because method signatures are different
after type erasure
|
With the merge of eclipse/microprofile-metrics#748, these are the only changes which are needed to make the TCK compatible with MP Metrics 5.0. I've now run this locally on my workstation with openliberty, incorporating this smallrye-metrics change: smallrye/smallrye-metrics#558 and microprofile-metrics-api 5.0.0-RC3 |
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tolerate the following breaking changes in MP Metrics 5.0, while retaining support for MP Metrics 4.0:
SnapshotGauge<T>changed toGauge<T extends Number>This does not include support for tolerating the removal of
@RegistryType. See #117Fixes #609