New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include extra tests for time limits #6
Comments
Add it to the list of TCK tests, see #92. And then this can be closed. |
If we don't have separate issues for tests where do we discuss the behaviour of the testcase before raising PR's? |
@mmusgrov you can discuss it in the issue #92 or on gitter/hangout. #92 should only act as a tracker so if you really feel the need to have a separate discussion in separate issue like this one I don't see any problem with it, just please link this issue as well as PR to the particular line of the test case in #92. |
Putting every discussion on #92 will become very difficult to parse, particularly if more than one TCK test is being discussed. |
I believe this particular one was migrated from the sandbox when you first moved the code base. But of course if there is an issue open just link it to the tracker. |
Some tests related to #233 to test timeout related stuff. Test AService A - Timeout 1 Hour Test calls service A, wait 1 sec, trigger recovery and verifies if LRA is cancelled. Test BService A - Timeout 500 ms test calls A and verifies if return is status 412 (precondition failed) since LRA is not active when Service B endpoint is called. |
Also include a test that verifies that the time limit is respected after a system crash. When the system restarts the time limit should become active again. If the time limit has already passed when the system comes back up then the test should check that the compensation callbacks are triggered. |
Also include a test that verifies that the time limit is respected after a system crash. When the system restarts the time limit should become active again. If the time limit has already passed when the system comes back up then the test should verify that the completing the transaction is not possible. |
PR merged |
Add a test for timelimits on LRAs. Check the behaviour for both the LRA.Type.SUPPORTS and
LRA.Type.REQUIRED annotations.
The text was updated successfully, but these errors were encountered: