Update base_metrics.xml to include processCpuTime and processCpuLoad #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yushan Lin <yushan.lin@ibm.com>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Signed-off-by: Yushan Lin <yushan.lin@ibm.com>
jmartisk
reviewed
Oct 17, 2019
| @@ -27,6 +27,7 @@ Changes marked with icon:bolt[role="red"] are breaking changes relative to previ | |||
| ** Clarified that metric registry implementations are required to be thread-safe. | |||
|
|
|||
| * Changes in 2.0 | |||
| ** Added ProcessCpuTime as a new optional base metric. | |||
There was a problem hiding this comment.
I'd suggest a new 2.0.3 section even though it will look a bit weird that we don't have 2.0.1 and 2.0.2
There was a problem hiding this comment.
see my comment at #467 (comment)
|
ok to test |
Signed-off-by: Yushan Lin <yushan.lin@ibm.com>
jmartisk
approved these changes
Oct 18, 2019
donbourne
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting the fix for #454 to 2.0.x
Signed-off-by: Yushan Lin yushan.lin@ibm.com