Remove JSON from spec + TCK #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2022
donbourne
requested changes
Aug 12, 2022
tck/rest/src/main/java/org/eclipse/microprofile/metrics/test/MetricAppBean.java
Outdated
Show resolved
Hide resolved
tck/rest/src/main/java/org/eclipse/microprofile/metrics/test/MetricAppBean.java
Show resolved
Hide resolved
|
|
||
| resp.then().statusCode(200) | ||
| .and() | ||
| .body(containsString("# TYPE countMe2_total counter")) |
There was a problem hiding this comment.
is the addition of "_total" something that's common across prometheus clients?
There was a problem hiding this comment.
I believe that's as per the Prometheus exposition format. The Meric name in the help and type must match the metric name.
https://prometheus.io/docs/instrumenting/exposition_formats/#comments-help-text-and-type-information
tck/rest/src/main/java/org/eclipse/microprofile/metrics/test/MpMetricTest.java
Outdated
Show resolved
Hide resolved
- Remove JSON from specification - Remove JSON related from MPMetricTest -- Replace removed JSON tests with Prom tests (some functionality was tested with JSON and not Prom/OM) - Update ReusedMetricTest to query for Prometheus format - Replace deprecated assertThat call in MultipleBeanInstancesTest - Rename any OpenMetrics mentions to Prometheus - MetricAppBean modified to use labels correctly (strict name x tag combination) - Removed JSON from Optional REST test (i.e. MpMetricOptionalTest) -- Need to validate/test/rewrite in separate PR as current impl unable to do so.
…ic name from all scopes
Channyboy
force-pushed
the
685-removeJSON
branch
from
faf1758
to
6217488
Compare
jgallimore
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Replace removed JSON tests with Prom tests (some functionality was tested with JSON and not Prom/OM)
-- Need to validate/test/rewrite in separate PR as current impl unable to do so.
Fixes #685
Fixes #693