Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JSON from spec + TCK #709

Merged
merged 3 commits into from Aug 16, 2022
Merged

Remove JSON from spec + TCK #709

merged 3 commits into from Aug 16, 2022

Commits on Aug 15, 2022

  1. Remove JSON from spec + TCK 

    - Remove JSON from specification
- Remove JSON related from MPMetricTest
-- Replace removed JSON tests with Prom tests (some functionality was tested with JSON and not Prom/OM)
- Update ReusedMetricTest to query for Prometheus format
- Replace  deprecated assertThat call in MultipleBeanInstancesTest
- Rename any OpenMetrics mentions to Prometheus
- MetricAppBean modified to use labels correctly (strict name x tag combination)
- Removed JSON from Optional REST test (i.e. MpMetricOptionalTest)
-- Need to validate/test/rewrite in separate PR as current impl unable to do so.
    @Channyboy
    Channyboy committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    524dca4 View commit details
    Browse the repository at this point in the history

  2. Update REST TCK to test for a /metrcs?name=<name> that gathers a metr… 

    …ic name from all scopes
    @Channyboy
    Channyboy committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    2cf60ff View commit details
    Browse the repository at this point in the history

  3. Address comments: typos

    @Channyboy
    Channyboy committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    6217488 View commit details
    Browse the repository at this point in the history