Mp 6 additional issues #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the refactoring, it's using the proposed changes from the MicroProfile Parent as a base (see eclipse/microprofile-parent#66). For details of the CVEs, see references here: https://mvnrepository.com/artifact/org.asciidoctor/asciidoctor-maven-plugin/1.5.8 (4 CVEs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Emily-Jiang as discussed in #298, here is the additional PR fixing existing issues for the locale configuration and much more important for removing at least 3 of 4 CVEs we have due to a very outdated AsciiDoctor Maven Plugin version and it's related dependencies. The major release change also requires a little refactoring here.
The last one will be solved with a new release of the plugin (see changelog here: https://github.com/asciidoctor/asciidoctor-maven-plugin/blob/main/CHANGELOG.adoc) , which could make the configuration much simpler in the future.