-
Notifications
You must be signed in to change notification settings - Fork 2.4k
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread sanitizer reveals missing locks #1374
Comments
Thanks for this. Out of interest, is the code using loop_start(), or threads external to the library? |
External threads in this case. Do you suspect a user error :) (we are calling |
Not at all, it's just good to know the situation. I've not look at it properly yet, but I'm curious to know your reasoning as to why you've removed the mutex from the callback calls. |
I found that |
|
I'm sorry, |
OK, thanks for pointing this out. The changes in locking of |
Further investigation reveals that the first change in that last diff (removing the access to |
Thanks, I've now added a commit that implements this. |
I recently ran a client's software with gcc's thread sanitizer enabled. It revealed some issues in mosquitto that I've worked around in a fork but I felt I should document them here. The problems are:
I've attached a very rough patch showing where the issues are.
The text was updated successfully, but these errors were encountered: