Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include: Declare gVERSION global as 'extern'. #1012

Closed

Conversation

besser82
Copy link
Contributor

Fixes build with '-fno-common'.

Fixes build with '-fno-common'.
@Propanu
Copy link
Contributor

Propanu commented May 7, 2020

@besser82, I have no issues merging this to the project but you need to sign the ECA. Let us know if you need help with that.

@ffontaine
Copy link
Contributor

It should be noted that this PR is needed to fix the build with gcc 10 (which defaults to -fno-common)

@tingleby
Copy link
Member

tingleby commented Sep 7, 2020

Cool @besser82 could you please take a look at the ECA check which we require to pull this.

@tingleby
Copy link
Member

tingleby commented Apr 7, 2021

@besser82 Could you please create an Eclipse account to sign/ack the ECA. Id like to merge this patch.

Before your contribution can be accepted by the project, you need to create and 
electronically sign the Eclipse Contributor Agreement (ECA) and sign 
off on the Eclipse Foundation Certificate of Origin. 

For more information, please visit

http://wiki.eclipse.org/Development_Resources/Contributing_via_Git

@jan-kiszka
Copy link
Contributor

What's the status here? I'm also in need for fixing this (and did so locally before seeing this one).

@tingleby
Copy link
Member

Merged, with aaa0a5c

@tingleby tingleby closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants