Add on board LED support #811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arfoll
suggested changes
Aug 29, 2017
There was a problem hiding this comment.
Generally looks very good, a few things need adding before merge:
- Needs a _close() function for the context
- Needs C++ API, and checking that SWIG APIs generated make sense
- It would be nice to create the table of 'what' LEDs are available on mraa_init() so that it can be queried, rather than guessing if it's there on mraa_led_init. This can probably be added after though.
This patch adds support for using on board LED through sysfs. Commonly available LED parameters are supported. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
|
@arfoll I've updated the PR with following changes:
I have left LED table as of now. Will add it once this PR gets in |
|
@arfoll this looks good to me now and it would be a great addition for the next tagged version of mraa. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for using on board LED through sysfs.
Commonly available LED parameters are supported.
Signed-off-by: Manivannan Sadhasivam manivannan.sadhasivam@linaro.org